The following document contains the results of PMD 4.2.2.
| Violation | Line |
|---|---|
| Return an empty array rather than null. | 93 - 95 |
| Violation | Line |
|---|---|
| The String literal "unchecked" appears 5 times in this file; the first occurrence is on line 61 | 61 |
| Violation | Line |
|---|---|
| The String literal " - " appears 4 times in this file; the first occurrence is on line 604 | 604 |
| Violation | Line |
|---|---|
| Caught exception is rethrown, original stack trace may be lost | 51 - 52 |
| Caught exception is rethrown, original stack trace may be lost | 55 - 56 |
| The String literal "FieldDataInvalidException" appears 7 times in this file; the first occurrence is on line 258 | 258 |
| Caught exception is rethrown, original stack trace may be lost | 434 |
| Violation | Line |
|---|---|
| Caught exception is rethrown, original stack trace may be lost | 80 - 81 |
| Caught exception is rethrown, original stack trace may be lost | 84 - 85 |
| Caught exception is rethrown, original stack trace may be lost | 88 - 89 |
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 284 - 293 |
| Use block level rather than method level synchronization | 299 - 319 |
| Non-static initializers are confusing | 398 - 401 |
| Violation | Line |
|---|---|
| Avoid unnecessary comparisons in boolean expressions | 61 |
| These nested if statements could be combined | 75 - 77 |
| Violation | Line |
|---|---|
| StringBuffer.append is called 2 consecutive times with literal Strings. Use a single append with a single String. | 61 |
| StringBuffer.append is called 2 consecutive times with literal Strings. Use a single append with a single String. | 61 |
| Violation | Line |
|---|---|
| Perhaps 'panel' could be replaced by a local variable. | 87 |
| Perhaps 'settings' could be replaced by a local variable. | 91 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 416 |
| Caught exception is rethrown, original stack trace may be lost | 500 |
| Caught exception is rethrown, original stack trace may be lost | 504 |
| Caught exception is rethrown, original stack trace may be lost | 508 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 563 |
| Violation | Line |
|---|---|
| Perhaps 'buttonCancel' could be replaced by a local variable. | 83 |
| Perhaps 'buttonSave' could be replaced by a local variable. | 84 |
| Perhaps 'buttonBar' could be replaced by a local variable. | 86 |
| Violation | Line |
|---|---|
| Possible unsafe assignment to a non-final static field in a constructor. | 88 |
| Violation | Line |
|---|---|
| Perhaps 'panel' could be replaced by a local variable. | 63 |
| Violation | Line |
|---|---|
| Perhaps 'buttonApply' could be replaced by a local variable. | 50 |
| Perhaps 'buttonClose' could be replaced by a local variable. | 51 |
| Perhaps 'settings' could be replaced by a local variable. | 55 |
| Ensure that resources like this Connection object are closed after use | 89 |
| Violation | Line |
|---|---|
| Perhaps 'buttonBar' could be replaced by a local variable. | 81 |
| Perhaps 'settings' could be replaced by a local variable. | 87 |
| Caught exception is rethrown, original stack trace may be lost | 445 |
| Violation | Line |
|---|---|
| Perhaps 'buttonBar' could be replaced by a local variable. | 80 |
| Perhaps 'list' could be replaced by a local variable. | 82 |
| Caught exception is rethrown, original stack trace may be lost | 485 |
| Violation | Line |
|---|---|
| Perhaps 'artistPanel' could be replaced by a local variable. | 69 |
| Violation | Line |
|---|---|
| Perhaps 'discPanel' could be replaced by a local variable. | 92 |
| Perhaps 'trackList' could be replaced by a local variable. | 95 |
| Perhaps 'tracks' could be replaced by a local variable. | 100 |
| Violation | Line |
|---|---|
| Perhaps 'trackPanel' could be replaced by a local variable. | 62 |
| Violation | Line |
|---|---|
| Perhaps 'filterPanel' could be replaced by a local variable. | 63 |
| Perhaps 'scrollPane' could be replaced by a local variable. | 64 |
| Violation | Line |
|---|---|
| A switch with less than 3 branches is inefficient, use a if statement instead. | 277 - 293 |
| Violation | Line |
|---|---|
| Perhaps 'navigationPanel' could be replaced by a local variable. | 94 |
| Use block level rather than method level synchronization | 495 - 497 |
| Use block level rather than method level synchronization | 504 - 506 |
| Violation | Line |
|---|---|
| Perhaps 'listScrollPane' could be replaced by a local variable. | 79 |
| Perhaps 'listModel' could be replaced by a local variable. | 83 |
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 266 - 268 |
| Use block level rather than method level synchronization | 319 - 325 |
| Violation | Line |
|---|---|
| Perhaps 'lafPanel' could be replaced by a local variable. | 48 |
| Violation | Line |
|---|---|
| Perhaps 'settings' could be replaced by a local variable. | 27 |
| Violation | Line |
|---|---|
| Perhaps 'file' could be replaced by a local variable. | 47 |
©
1999-2008
Melloware Inc